From 545c5a016eba8128d4ade02aa506b8821a00a38c Mon Sep 17 00:00:00 2001
From: Adam Soltys <asoltys@gmail.com>
Date: Tue, 8 Nov 2022 02:22:18 -0800
Subject: fix 2fa

---
 src/routes/(app)/[username]/settings/+page.server.js  | 11 -----------
 src/routes/(app)/[username]/settings/+page.svelte     | 11 ++++-------
 src/routes/(app)/[username]/settings/_pos.svelte      | 13 ++-----------
 src/routes/(app)/[username]/settings/_security.svelte | 17 +++++++++++------
 4 files changed, 17 insertions(+), 35 deletions(-)

(limited to 'src/routes/(app)/[username]/settings')

diff --git a/src/routes/(app)/[username]/settings/+page.server.js b/src/routes/(app)/[username]/settings/+page.server.js
index 713841c2..482b70b1 100644
--- a/src/routes/(app)/[username]/settings/+page.server.js
+++ b/src/routes/(app)/[username]/settings/+page.server.js
@@ -1,16 +1,5 @@
 import { invalid } from '@sveltejs/kit';
 import { auth, get, post } from '$lib/utils';
-import Qr from 'qrcode-base64';
-
-export async function load({ locals: { user } }) {
-	return {
-		otpQr: Qr.drawImg(
-			`otpauth://totp/coinos:${user.username}?secret=${user.otpsecret}&period=30&digits=6&algorithm=SHA1&issuer=coinos`,
-			{ size: 600 }
-		)
-	};
-}
-
 export const actions = {
 	default: async ({ cookies, locals, request }) => {
 		let form = Object.fromEntries(await request.formData());
diff --git a/src/routes/(app)/[username]/settings/+page.svelte b/src/routes/(app)/[username]/settings/+page.svelte
index f4660fab..250087c1 100644
--- a/src/routes/(app)/[username]/settings/+page.svelte
+++ b/src/routes/(app)/[username]/settings/+page.svelte
@@ -15,11 +15,11 @@
 	export let data;
 	export let form;
 
-	let { user, rates, token } = data;
+	let { user, token } = data;
 	$: update(data);
-	let update = () => ({ user, rates, token } = data);
+	let update = () => ({ user, token } = data);
 
-	$: form && ({ user } = form);
+	$: form?.user && ({ user } = form);
 
 	$: if (form?.message?.startsWith('Pin')) {
 		failure('Wrong pin, try again');
@@ -39,7 +39,6 @@
 	let loading, submit;
 	let save = async (msg) => {
 		loading = true;
-		if (typeof msg !== 'string') msg = 'Settings saved';
 
 		try {
 			if ($avatarUpload) {
@@ -49,8 +48,6 @@
 			if ($bannerUpload) {
 				await upload($bannerUpload.file, $bannerUpload.type, $bannerUpload.progress, token);
 			}
-
-			success(msg);
 		} catch (e) {
 			console.log(e);
 			failure('Something went wrong');
@@ -85,7 +82,7 @@
 			{/each}
 		</div>
 
-		<svelte:component this={comp} {user} {rates} {submit} />
+		<svelte:component this={comp} {user} {submit} />
 	</div>
 
 	<div
diff --git a/src/routes/(app)/[username]/settings/_pos.svelte b/src/routes/(app)/[username]/settings/_pos.svelte
index cf4a5ece..ccbeeff4 100644
--- a/src/routes/(app)/[username]/settings/_pos.svelte
+++ b/src/routes/(app)/[username]/settings/_pos.svelte
@@ -2,9 +2,9 @@
 	import { Icon, Toggle } from '$comp';
 	import { t } from '$lib/translations';
 	import { success, failure } from '$lib/utils';
+	import { page } from '$app/stores';
 
-	export let rates, user;
-
+	let { rates, user } = $page.data;
 	const fiats = Object.keys(rates);
 </script>
 
@@ -16,12 +16,3 @@
 		{/each}
 	</select>
 </div>
-
-<!-- TODO
-<div>
-	<label for="unit" class="font-bold block mb-1">{$t('user.settings.btcUnit')}</label>
-	<select disabled name="unit" class="select-styles block py-3 w-full" bind:value={user.unit}>
-		<option value="SAT">{$t('user.settings.satoshis')} (SAT)</option>
-		<option value="BTC">{$t('user.settings.bitcoin')} (BTC)</option>
-	</select>
-</div> -->
diff --git a/src/routes/(app)/[username]/settings/_security.svelte b/src/routes/(app)/[username]/settings/_security.svelte
index 98b9b503..4bdb00d4 100644
--- a/src/routes/(app)/[username]/settings/_security.svelte
+++ b/src/routes/(app)/[username]/settings/_security.svelte
@@ -5,9 +5,10 @@
 	import { Pincode, PincodeInput } from 'svelte-pincode';
 	import { post, success, failure } from '$lib/utils';
 	import { pin as current } from '$lib/store';
+	import { invalidate } from '$app/navigation';
+	import { page } from '$app/stores';
 
 	export let user, submit;
-
 	let settingPin, setting2fa, disabling2fa;
 
 	let token = '';
@@ -23,6 +24,12 @@
 
 	$: pin = pinCode.join('');
 
+	let otp;
+	$: pinChange($current);
+	let pinChange = async (pin) => {
+		otp = await post('/otpsecret', { pin });
+	};
+
 	let locked;
 	$: verifyCode.join('').length > 5 && checkPin();
 	let checkPin = async () => {
@@ -108,8 +115,6 @@
 			failure('Failed to disable 2FA, try again');
 		}
 	};
-
-	$: otpUri = `otpauth://totp/coinos:${user.username}?secret=${user.otpsecret}&period=30&digits=6&algorithm=SHA1&issuer=coinos`;
 </script>
 
 <div>
@@ -172,13 +177,13 @@
 		{$t('user.settings.twofaDescription')}
 	</p>
 	{#if setting2fa}
-		<a href={otpUri}>
-			<Qr text={otpUri} />
+		<a href={otp.uri}>
+			<Qr src={otp.qr} />
 		</a>
 
 		<div class="text-center my-4">
 			{$t('user.settings.accountId')}<br />
-			<b>{user.otpsecret}</b>
+			<b>{otp.secret}</b>
 		</div>
 
 		<div class="text-center my-4">
-- 
cgit v1.2.3